-
Notifications
You must be signed in to change notification settings - Fork 1
Detailed balance #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Detailed balance #52
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #52 +/- ##
============================================
+ Coverage 0.00% 98.50% +98.50%
============================================
Files 1 2 +1
Lines 2 67 +65
============================================
+ Hits 0 66 +66
+ Misses 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: rozyczko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea with separating utilities from the rest of the code.
A few points added on how to improve the code.
The rest looks good!
""" | ||
|
||
# Input validation | ||
if not isinstance(divide_by_temperature, bool): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type checks already test the types. If we enforce those, these checks aren't necessary
@rozyczko Just double checking, is it OK to merge? :) |
Utility function to calculate the detailed balance factor as discussed here: easyscience/dynamics#6
Includes the option to normalise by temperature. Takes various inputs and outputs a np array. I may want to later output a scipp array, but not yet.