Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Foundry v12 & dnd5e v4 #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jagoe
Copy link

@jagoe jagoe commented Oct 1, 2024

  • Use .item-row container to display actions as a row again
  • Mark as compatible with Foundry 12.331
  • Minor refactoring

@jagoe jagoe force-pushed the dnd5e-v4-compatibility branch from c705ba6 to 683b47e Compare October 1, 2024 10:48
@andriypartyshev
Copy link

any update on when this will be accepted?

@eastcw
Copy link
Owner

eastcw commented Oct 31, 2024

Sorry, I've not been in a position to monitor project this in a while. This looks fine at first glance, I'll try and test it this week and get an update out soon

@eastcw eastcw linked an issue Oct 31, 2024 that may be closed by this pull request
@RandomLegend
Copy link

RandomLegend commented Dec 28, 2024

Heyho,

do you believe you find the time to test this and if yes, merge and update it?
If not, can someone tell me if, and if yes how, i could implement the fix written by @jagoe into my installation manually?

EDIT: i created the module/scripts folder, created the api.js and changed the module.json and actor-actions-list-v2.hbs manually and that worked. Thanks @jagoe !

@Karnis101
Copy link

I have been trying to fix this for my players but I do not know coding. How to I get it back to a row? Right now it is really messed up?

@WitchClaireBear
Copy link

I tried doing the same as @RandomLegend and got it mostly working but damages aren't showing. I did some manual exploration and it seems like labels.derivedDamage isn't working on the character sheet. I did have luck with using labels.damages (in actor-actions-list-v2.hbs) don't know if this is a version difference.

Foundry: 12 Stable Build 331
DnD 5e: v4.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to v12
6 participants