feat(settings): change card detail control in CheckpointSettings + webview default (B3a v2-9, epic #1375) - #52
Open
easonLiangWorldedtech wants to merge 1 commit into
Conversation
Review statusThanks for contributing. This comment tracks the review sequence and the next action. Current step: Required CI passed. Waiting for automated review of the latest commit. If automated review does not start, a maintainer must restart it. Review-state labels are managed by this workflow; do not edit them manually. |
easonLiangWorldedtech
force-pushed
the
feat/fws-v2-8b-editsearch-wiring
branch
from
September 6, 2026 02:30
4945207 to
63d9b09
Compare
easonLiangWorldedtech
force-pushed
the
feat/fws-v2-9-settings-ui
branch
from
September 6, 2026 02:30
4b8fdb6 to
7ae24af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Settings/UI tail of the B3a change-card feature (epic Zoo-Code-Org#1375), stacked on #51 (v2-8b):
CheckpointSettings: new "Change card detail" control (summary/full) bound to localcachedStateand saved through theupdateSettingspayload (changeCardDetail), per the SettingsView cache pattern.SettingsView: wiring for the new control;changeCardDetailadded to the settings cache.ExtensionState:changeCardDetaildefaults to"summary"increateInitialExtensionState;mergeExtensionStatepreserves the stored value when the incoming state omits the key.settings:checkpoints.changeCardDetail.{label,description}in all 18 locales (nested undercheckpoints, sibling ofperWrite).CheckpointSettings/SettingsViewspecs +ExtensionStateContextspec (pre-hydration defaults, merge retention with non-default fixtures).Line count / split rationale
355 changed lines (337+/18-) across 24 files — below the 400 soft design target. The file count is inflated by the 18 locale JSONs (each +4 lines for the two new keys); the actual logic change is the settings control wiring plus the context default/merge handling.
Not included here (later v2 PRs)
Local gates
CheckpointSettingsassertions pinning the searchable label and the rendered description).--prune-suppressions --max-warnings=0on the 6 TS/TSX files: clean.e6133ebed; diff content unchanged by the rebase onto49452076d).