Implement Validation Phase Ruleset #47
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #44.
Rulses Implemented
additionalTypeof the ValidationCheck entity MUST be set to https://w3id.org/shp#ValidationCheck (i)RootDataEntity-->mentionsSHOULD referenceValidationCheckValidationCheckMUST be of typeAssessActionValidationCheckMUST provide a human-readable summary of the review and result (ii)ValidationCheck-->objectSHOULD point to the root of the RO-CrateValidationCheck-->instrumentSHOULD reference an object with @id https://w3id.org/5s-crate/0.4ValidationCheckSHOULD haveactionStatuspropertyValidationCheck-->actionStatusMUST have one of the allowed values(i) This is not an actual rule, but rather a definition of what constitutes a ValidationCheck entity. As such it was not implemented given its axiomatic nature.
(ii) This rule is implicitly included in rule 3, hence it was not implemented.
(iii) This cannot be entirely done without a manual check. Here we only check that the name property of
ValidationCheckis a string of at least 10 characters.Rules Not Implemented (need clarifications)
ValidationCheck-->objectMAY point to additional entities, as required by TREs/workflows, as an array of objects.ValidationCheck-->instrumentMAY reference additional expected input parameters, as required by TREs/workflows, as an array of instrumentsValidationCheck-->objectMAY reference additional checks of provided input parameters against expected, as required by TREs/workflows, as an array of objects