feat: improve input handling, domain validation and UX #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Input handling improvements - Changed reading() to use 'read -rep' for readline support - Arrow keys now work for cursor navigation in input fields - Better handling of UTF-8/Cyrillic characters with backspace ## Domain input validation - Added reading_domain() function with built-in validation loop - Validates domain format before DNS lookup (prevents dig errors) - Only allows valid domain characters (a-z, 0-9, -, .) - Shows friendly error for Cyrillic/invalid input (INVALID_DOMAIN key) - New prompt logic: y=continue, n=re-enter, Enter=abort ## Menu navigation improvements - Invalid menu choice now returns to menu instead of exiting script - Domain abort returns to install menu instead of exiting - Better UX - users can correct mistakes without restarting ## Localization - Updated CONFIRM_PROMPT with new y/n/Enter options (EN/RU) - Added INVALID_DOMAIN error message (EN/RU) ## Functions modified - reading(): added readline support (-e flag) - reading_domain(): new function with validation and retry loop - check_domain(): new return codes (0=ok, 1=warning+continue, 2=retry, 3=abort) - install_remnawave(), install_remnawave_panel(), install_remnawave_node() - installation(), installation_panel(), installation_node() - manage_install(): handle return codes for menu navigation - Main menu and template menu: return to menu on invalid input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input handling improvements
Domain input validation
Menu navigation improvements
Localization
Functions modified