Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release #2353

Merged
merged 1 commit into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .changeset/curvy-bobcats-attend.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/four-mangos-hug.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/purple-seals-deliver.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/strong-grapes-work.md

This file was deleted.

12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# eBayUI-Core Changelog

## 14.6.0

### Minor Changes

- [#2351](https://github.com/eBay/ebayui-core/pull/2351) [`8024cfe`](https://github.com/eBay/ebayui-core/commit/8024cfe2a7db3c6e21c0fbbe1edda25198358694) Thanks [@LuLaValva](https://github.com/LuLaValva)! - feat(eek): added size option

- [#2348](https://github.com/eBay/ebayui-core/pull/2348) [`981e76a`](https://github.com/eBay/ebayui-core/commit/981e76ac2d00d961a552a59dfa3914b3f1148516) Thanks [@saiponnada](https://github.com/saiponnada)! - docs(contributing): updated tests section

- [#2337](https://github.com/eBay/ebayui-core/pull/2337) [`9c308b4`](https://github.com/eBay/ebayui-core/commit/9c308b46736f2ac646cec07d4e92f2ada1a10954) Thanks [@agliga](https://github.com/agliga)! - feat: added async loading instead of cdn loader

- [#2352](https://github.com/eBay/ebayui-core/pull/2352) [`a5b2e69`](https://github.com/eBay/ebayui-core/commit/a5b2e6967a53593a2766f651ebed89328b7e093f) Thanks [@WinkeeFace](https://github.com/WinkeeFace)! - fix(ebay-carousel): fix width calculation for last pill when font not loaded (#2344)

## 14.5.1

### Patch Changes
Expand Down
82 changes: 41 additions & 41 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@ This page contains instructions and guidelines for anybody contributing code to

## Table of Contents

- [Development](#development)
- [Pull Requests](#pull-requests)
- [Branching Strategy](#branching-strategy)
- [Unit Tests](#unit-tests)
- [Definition of Done](#definition-of-done)
- [Naming Scheme](#naming-scheme)
- [Releases](#releases)
- [Development](#development)
- [Pull Requests](#pull-requests)
- [Branching Strategy](#branching-strategy)
- [Unit Tests](#unit-tests)
- [Definition of Done](#definition-of-done)
- [Naming Scheme](#naming-scheme)
- [Releases](#releases)

## Development

This section includes information on system requirements, running the local server, tests and package scripts.

### System Requirements

- [Node.js](https://nodejs.org/en/)
- [Node.js](https://nodejs.org/en/)

Clone this repo to your local environment then run `npm i` to install all dependencies.

Expand Down Expand Up @@ -71,20 +71,20 @@ If you are creating a new component or significantly altering an existing one, p

We ask this because:

- we want to avoid cases where developers build something that does not align with our wants & needs
- we want to be able to carefully plan our sprint and test cycles with minimal disruption
- we want to avoid cases where two developers duplicate work
- we want to avoid cases where developers build something that does not align with our wants & needs
- we want to be able to carefully plan our sprint and test cycles with minimal disruption
- we want to avoid cases where two developers duplicate work

### Writing Code

The contents of a pull request should be related to a single issue only (or, at most, perhaps two very closely related issues). The reviewer has the right to reject a pull request that contains anything non-issue related.

Whilst it may be tempting to fix any [broken windows](https://www.rtuin.nl/2012/08/software-development-and-the-broken-windows-theory/) that you encounter, we ask you not to because:

- it can distract the reviewer from the main issue at hand
- it can add additional time needed for the reviewer
- it can increase the chance of regressions
- it can make rollbacks more difficult
- it can distract the reviewer from the main issue at hand
- it can add additional time needed for the reviewer
- it can increase the chance of regressions
- it can make rollbacks more difficult

So please be a good citizen and create separate issues or pull requests for any broken windows that you find.

Expand Down Expand Up @@ -159,10 +159,10 @@ A milestone branch will be deleted after it has been merged into master. There i

With this strategy, there are rarely more than a handful of branches at any one moment in time:

- master branch (reflects current production code/release)
- next minor or major milestone branch
- next patch milestone branch
- _n_ number of feature/issue branches (usually 1 - 3)
- master branch (reflects current production code/release)
- next minor or major milestone branch
- next patch milestone branch
- _n_ number of feature/issue branches (usually 1 - 3)

## Unit Tests

Expand All @@ -176,12 +176,12 @@ Browser side testing is predominantly concerned with the testing of _state_. For

For both types of tests, please observe the following golden rules:

- A test should only test one thing
- Watch out for the words 'and' & 'or' in your test description!
- A test should not contain conditional logic
- We don't want to have to write tests for our tests!
- A test description should avoid interpolated strings
- Test descriptions should be human readable (readable != parsable)
- A test should only test one thing
- Watch out for the words 'and' & 'or' in your test description!
- A test should not contain conditional logic
- We don't want to have to write tests for our tests!
- A test description should avoid interpolated strings
- Test descriptions should be human readable (readable != parsable)

Above all, all aspects of a test should be human readable. A simple litmus test for this is that anybody should be able to read the test and, within a few seconds, be able to tell you what the _purpose_ of the test is. If they are confused, or ask questions, then it is not a well written test. Go back and refactor!

Expand All @@ -191,28 +191,28 @@ A component is considered "done", and ready for merge into release branch, when

1. Foundational layer review

- Visual design (DS6)
- Markup structure (Bones)
- Accessibility pattern (MIND)
- CSS (Skin)
- Visual design (DS6)
- Markup structure (Bones)
- Accessibility pattern (MIND)
- CSS (Skin)

2. Component layer review

- Tag API
- Event API
- Unit tests
- Integration test
- Performance test
- Documentation
- Tag API
- Event API
- Unit tests
- Integration test
- Performance test
- Documentation

3. Code review

- Linter should catch syntax and style issues
- Prefer performance over readability, but readability over "space saving" code
- Apply the single-responsibility principle to functions
- Refactor long functions into several small functions
- Identify and move common utility functions to libraries or static methods
- All CSS should come from Skin
- Linter should catch syntax and style issues
- Prefer performance over readability, but readability over "space saving" code
- Apply the single-responsibility principle to functions
- Refactor long functions into several small functions
- Identify and move common utility functions to libraries or static methods
- All CSS should come from Skin

## Naming Scheme

Expand Down
Loading