-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of the tutorials #378
Conversation
@sonja-sechi is this PR ready for review? There is no reviewer assigned. In any case, there's already a change needed: folder names should not contain commas |
I assigned you and me but I think after push the button in Git (no sure it would have work) so sorry about that. In any case I am gonna change the name of the folder and subfolders.
Sonja
…________________________________
From: Anastasis Giannousakis ***@***.***>
Sent: Thursday, January 16, 2025 9:12:06 AM
To: e3modelling/OPEN-PROM ***@***.***>
Cc: Sechi, Sonja ***@***.***>; Mention ***@***.***>
Subject: Re: [e3modelling/OPEN-PROM] Update of the tutorials (PR #378)
You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
[CAUTION - EXTERNAL EMAIL] Do not click links, open attachments, or reply to sender unless you recognise the sender, expect the email, and know the content is safe. Contact the helpdesk if you have any concerns.
@sonja-sechi<https://github.com/sonja-sechi> is this PR ready for review? There is no reviewer assigned. In any case, there's already a change needed: folder names should not contain commas
—
Reply to this email directly, view it on GitHub<#378 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BOENQIC3U7MGEJGTHAUOPXT2K5SVNAVCNFSM6AAAAABVHRWML2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJUG44DINJTHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--------------------------------------------------------------------------------------------------------------------------------------------------------------
This e-mail and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are
addressed. If you have received this e-mail in error please notify the sender immediately and delete this e-mail from your system.
Please note that any views or opinions presented in this e-mail are solely those of the author and do not necessarily represent those
of Ricardo (save for reports and other documentation formally approved and signed for release to the intended recipient). Only Directors
are authorised to enter into legally binding obligations on behalf of Ricardo. Ricardo may monitor outgoing and incoming e-mails and
other telecommunications systems. By replying to this e-mail you give consent to such monitoring. The recipient should check e-mail and
any attachments for the presence of viruses. Ricardo accepts no liability for any damage caused by any virus transmitted by this e-mail.
"Ricardo" means Ricardo plc and its subsidiary companies.
Ricardo plc is a public limited company registered in England with registered number 00222915.
The registered office of Ricardo plc is Shoreham Technical Centre, Shoreham-by Sea, West Sussex, BN43 5FG.
--------------------------------------------------------------------------------------------------------------------------------------------------------------
|
There's a difference between the "Assignee" and the "Reviewer". The Assignee is someone who was involved in the development of the new feature contained in the PR, whereas the Reviewer is the person who will review the PR and approve or ask for changes. I'm supposed to be the Reviewer here, not an Assignee |
Few details to be checked: The running of OPEN-PROM with dummy data (Tutorial 04) should be double checked, not sure the issue with the input file was solved. I noticed also that in the tag version there is not the config.template file as in the current version of OPEN-PROM (not sure that this wanted or not). In Tutorial 05 the description of the tools in REPORTING, SCENTOOL, COMPARE SCENERARIOS, OPEN-PROM LIVE can be improved with more details. Tutorial 06 about the regionalization is a work in project, it could be removed. Not sure if it will be a tutorial on how to change the regionalization. |
Changed and update the structure of the tutorials, update of the contents.