Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the tutorials #378

Merged
merged 11 commits into from
Jan 21, 2025
Merged

Update of the tutorials #378

merged 11 commits into from
Jan 21, 2025

Conversation

sonja-sechi
Copy link
Contributor

Changed and update the structure of the tutorials, update of the contents.

@giannou
Copy link
Member

giannou commented Jan 16, 2025

@sonja-sechi is this PR ready for review? There is no reviewer assigned. In any case, there's already a change needed: folder names should not contain commas

@sonja-sechi
Copy link
Contributor Author

sonja-sechi commented Jan 16, 2025 via email

@giannou
Copy link
Member

giannou commented Jan 16, 2025

I assigned you and me but I think after push the button in Git (no sure it would have work) so sorry about that. In any case I am gonna change the name of the folder and subfolders

There's a difference between the "Assignee" and the "Reviewer". The Assignee is someone who was involved in the development of the new feature contained in the PR, whereas the Reviewer is the person who will review the PR and approve or ask for changes. I'm supposed to be the Reviewer here, not an Assignee

@giannou giannou self-requested a review January 16, 2025 09:11
@giannou giannou removed their assignment Jan 16, 2025
@giannou giannou removed their request for review January 16, 2025 09:13
@sonja-sechi sonja-sechi requested a review from giannou January 16, 2025 14:26
@sonja-sechi
Copy link
Contributor Author

Few details to be checked:

The running of OPEN-PROM with dummy data (Tutorial 04) should be double checked, not sure the issue with the input file was solved. I noticed also that in the tag version there is not the config.template file as in the current version of OPEN-PROM (not sure that this wanted or not).

In Tutorial 05 the description of the tools in REPORTING, SCENTOOL, COMPARE SCENERARIOS, OPEN-PROM LIVE can be improved with more details.

Tutorial 06 about the regionalization is a work in project, it could be removed. Not sure if it will be a tutorial on how to change the regionalization.

@giannou giannou linked an issue Jan 20, 2025 that may be closed by this pull request
Redmonkeycloud
Redmonkeycloud previously approved these changes Jan 21, 2025
@sonja-sechi sonja-sechi merged commit 8b56c54 into main Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework Tutorials
3 participants