Skip to content

Deno workarounds #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Deno workarounds #73

wants to merge 2 commits into from

Conversation

mishushakov
Copy link
Member

  • Updated to the latest version of Deno
  • Added a warmup script that runs Deno session once

0div
0div requested changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@0div 0div left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls also update the deno.test.ts if indeed the deno update fixes imports not needed npm: prefix ?

template/start-up.sh
fi

deno_session_id=$(echo "${deno_response}" | jq -r '.id')
curl -s -X DELETE "localhost:8888/api/sessions/${deno_session_id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: why are deleting the session here but not for the python kernel?

template/test.Dockerfile
@@ -24,7 +24,7 @@ RUN npm install -g --unsafe-perm ijavascript
RUN ijsinstall --install=global

# Deno Kernel
COPY --from=denoland/deno:bin-2.0.4 /deno /usr/bin/deno
COPY --from=denoland/deno:bin-2.2.5 /deno /usr/bin/deno
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this solves the import problem correct?

@mishushakov mishushakov marked this pull request as draft March 26, 2025 09:56
@mishushakov
Copy link
Member Author

I converted to draft, I still need to do some further investigation, particularly I have to make it start reliable on new context

@ValentaTomas ValentaTomas added the improvement Improvement for current functionality label Mar 26, 2025
@ValentaTomas Linear
Copy link
Member

Please improve the name to express what the PR will achieve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0div 0div 0div requested changes

@jakubno jakubno Awaiting requested review from jakubno jakubno is a code owner

@ValentaTomas ValentaTomas Awaiting requested review from ValentaTomas ValentaTomas is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@mishushakov mishushakov

Labels
improvement Improvement for current functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mishushakov @ValentaTomas @0div