Skip to content

🐛 Fix agg metrics, don't use "for .. in .." on JS arrays #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shankari merged 1 commit into from
Aug 24, 2024
Merged

🐛 Fix agg metrics, don't use "for .. in .." on JS arrays #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions www/js/metrics/CarbonFootprintCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,14 @@ const CarbonFootprintCard = ({ userMetrics, aggMetrics }: Props) => {

// Issue 422:
// https://github.com/e-mission/e-mission-docs/issues/422
let aggCarbonData: MetricsSummary[] = [];
for (let i in aggThisWeekSummary) {
aggCarbonData.push(aggThisWeekSummary[i]);
if (isNaN(aggCarbonData[i].values)) {
let aggCarbonData: MetricsSummary[] = aggThisWeekSummary.map((summaryEntry) => {
if (isNaN(summaryEntry.values)) {
logWarn(`WARNING in calculating groupCarbonRecords: value is NaN for mode
${aggCarbonData[i].key}, changing to 0`);
aggCarbonData[i].values = 0;
${summaryEntry.key}, changing to 0`);
summaryEntry.values = 0;
}
}
return summaryEntry;
});

let groupRecords: { label: string; x: number | string; y: number | string }[] = [];

Expand Down
13 changes: 6 additions & 7 deletions www/js/metrics/CarbonTextCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,14 @@ const CarbonTextCard = ({ userMetrics, aggMetrics }: Props) => {

// Issue 422:
// https://github.com/e-mission/e-mission-docs/issues/422
let aggCarbonData: MetricsSummary[] = [];
for (let i in aggThisWeekSummary) {
aggCarbonData.push(aggThisWeekSummary[i]);
if (isNaN(aggCarbonData[i].values)) {
let aggCarbonData: MetricsSummary[] = aggThisWeekSummary.map((summaryEntry) => {
if (isNaN(summaryEntry.values)) {
logWarn(`WARNING in calculating groupCarbonRecords: value is NaN for mode
${aggCarbonData[i].key}, changing to 0`);
aggCarbonData[i].values = 0;
${summaryEntry.key}, changing to 0`);
summaryEntry.values = 0;
}
}
return summaryEntry;
});

let groupText: { label: string; value: string }[] = [];

Expand Down