Repository navigation
Add Indonesian, Traditional Chinese and Turkish locales - #41
Merged
devin-ai-integration[bot] merged 2 commits intoNov 11, 2026
Merged
Conversation
Co-Authored-By: Kamil Dzieniszewski <kamil.dzieniszewski@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Co-Authored-By: Kamil Dzieniszewski <kamil.dzieniszewski@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three locales:
id(Indonesian),zh_TW(Traditional Chinese) andtr(Turkish). Indonesia is the 3rd country by Chrome users (49 of 349 weekly users) and had no translation, so those users saw the English popup, welcome page and store name._locales/{id,zh_TW,tr}/messages.json: all 100 keys fromen, same key order and placeholders.store-assets/store-descriptions.md: short and detailed Chrome Web Store descriptions for the three languages (short descriptions are 69, 27 and 74 characters, under the 132 limit).scripts/smoke.js: the header-geometry check expects 18 locales instead of 15.CHANGELOG.md: entry under Unreleased.The translations are machine-written by me and have not been checked by a native speaker.
The store listing text only takes effect once it is pasted into the Chrome dashboard for each new language; this PR does not do that.
Screenshots
Popup in Chromium started with
--lang=id,zh-TWandtr(380×600 viewport, no scrolling):Welcome page in the same three languages:
Testing
npm run check: 49 pass, 0 fail (locales.test.jschecks every locale has the same keys and placeholders asen).npm run smoke:SMOKE PASSED. Popup heights with the rating banner:id=574px,tr=574px,zh_TW=581px; with the What's new banner:id=587px,tr=572px,zh_TW=562px. All 18 locales stay under 600px.chrome.i18n.getUILanguage()returnedid,zh-TWandtrand the popup title was translated.Link to Devin session: https://app.devin.ai/sessions/ef68d30f1eba41589b2f4c6b1ef98aea
Open in Devin Desktop: https://app.devin.ai/desktop/session/ef68d30f1eba41589b2f4c6b1ef98aea?variant=devin
Requested by: @dzienisz