Repository navigation
Canary: check the miniplayer on live YouTube - #40
Merged
devin-ai-integration[bot] merged 3 commits intoNov 11, 2026
Merged
Conversation
Co-Authored-By: Kamil Dzieniszewski <kamil.dzieniszewski@gmail.com>
Co-Authored-By: Kamil Dzieniszewski <kamil.dzieniszewski@gmail.com>
… screenshot Co-Authored-By: Kamil Dzieniszewski <kamil.dzieniszewski@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
devin-ai-integration
Bot
changed the base branch from
devin/1794422026-miniplayer-controls
to
main
November 11, 2026 18:58
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #38 (the miniplayer fix); the base branch is that PR's branch, so the diff here is only the canary.
The weekly live-YouTube canary checked the watch player and an embedded player. The miniplayer reuses
#movie_playerwith a different layout, and the two bugs fixed in #38 went unnoticed.scripts/canary.jsnow has a third scenario, Miniplayer, run on the same watch page:i(up to 3 times) until#movie_player.ytp-player-minimized .ytp-miniplayer-uiappears;.ytp-miniplayer-ui,.ytp-miniplayer-close-button,.ytp-play-button,.ytp-progress-bar-container,.ytp-progress-list;border-radius: 50%,.ytp-time-wrapperhas no dark background,.ytp-progress-listis 12px, and the progress bar container sits on the player's bottom edge and inside the player;canary-artifacts/mini-player.png.If the watch player is not ready or the miniplayer never opens, the scenario is INCONCLUSIVE, like the other two, and does not fail the run. Behind YouTube's bot wall the miniplayer style failures are downgraded to INCONCLUSIVE the same way as the watch ones.
Screenshots
canary-artifacts/mini-player.pngfrom local headed runs. Left: this canary against the 2.2.2 CSS (it fails). Right: against the CSS from #38 (it passes).Testing
npm run checkpasses (49 tests).xvfb-run -a npm run canarylocally, live YouTube, 6 runs with the Miniplayer: round button backgrounds, keep the larger progress bar on the bottom edge #38 CSS: all Miniplayer checks PASS, exit 0.overlay-fix.cssfrommain: exit 1 withRound miniplayer button backgrounds — got 0px and 0pxNo dark box behind the miniplayer time — got rgba(0, 0, 0, 0.9)Progress bar on the miniplayer bottom edge — got offset 219, inside falseionce was INCONCLUSIVE in 1 of 2 runs (the miniplayer did not open), which is why it now waits for the video and retries.Link to Devin session: https://app.devin.ai/sessions/ef68d30f1eba41589b2f4c6b1ef98aea
Open in Devin Desktop: https://app.devin.ai/desktop/session/ef68d30f1eba41589b2f4c6b1ef98aea?variant=devin
Requested by: @dzienisz