Skip to content

Embedded player: round dark backgrounds behind the top and full screen buttons - #39

Merged
devin-ai-integration[bot] merged 2 commits into
mainfrom
devin/1794422229-embed-controls
Nov 11, 2026
Merged

devin-ai-integration[bot] merged 2 commits into
mainfrom
devin/1794422229-embed-controls

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

In the embedded player (youtube.com/embed in an iframe) the extension drew square dark boxes behind the sound, subtitles, settings and full screen buttons.

Cause: overlay-fix.css sets a dark background-color on #player-controls button.icon-button, .ytmMuteButtonButton and .ytmClosedCaptioningButtonButton. Those are square 48px hit areas with border-radius: 0. Only the play button has its own round shape.

Fix, embed selectors only:

#player-controls button.icon-button, .ytmMuteButtonButton, .ytmClosedCaptioningButtonButton
  { border-radius: 50% }
/* full screen: YouTube already draws a round 36px area inside the 48px button */
#player-controls button.icon-button.fullscreen-icon { background-color: transparent }
#player-controls .player-bottom-controls-fullscreen-icon-visible-area { background-color: <same dark color> }

The lighter band across the middle of the video is the existing top/bottom gradient (clear in the middle by design). This PR does not change it.

Screenshots

Real YouTube embed in a local iframe page, headed Chromium, default settings. Before (2.2.2) on the left, this PR on the right:

Embed before and after

This PR with default settings (left) and with yellow highlight and Clear controls (right):

Embed with different settings

Testing

  • npm run check (49 tests) and npm run smoke pass.
  • Both embed fixtures now include the full screen button; the smoke test checks the round mute background, the transparent full screen hit area and that its inner area gets the extension's dark color.
  • The smoke locator for the icon fill now targets the play button, because button.icon-button svg path matched two buttons after the fixture change.
  • Not checked in Firefox on live YouTube.

Link to Devin session: https://app.devin.ai/sessions/ef68d30f1eba41589b2f4c6b1ef98aea
Open in Devin Desktop: https://app.devin.ai/desktop/session/ef68d30f1eba41589b2f4c6b1ef98aea?variant=devin
Requested by: @dzienisz

…n buttons

Co-Authored-By: Kamil Dzieniszewski <kamil.dzieniszewski@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 024b132e-8fcc-40b9-8bfc-184dfe02ca65

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Co-Authored-By: Kamil Dzieniszewski <kamil.dzieniszewski@gmail.com>
@devin-ai-integration
devin-ai-integration Bot merged commit b79b358 into main Nov 11, 2026
5 checks passed
@devin-ai-integration devin-ai-integration Bot mentioned this pull request Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant