Repository navigation
Embedded player: round dark backgrounds behind the top and full screen buttons - #39
Merged
Merged
Conversation
…n buttons Co-Authored-By: Kamil Dzieniszewski <kamil.dzieniszewski@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Co-Authored-By: Kamil Dzieniszewski <kamil.dzieniszewski@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the embedded player (
youtube.com/embedin an iframe) the extension drew square dark boxes behind the sound, subtitles, settings and full screen buttons.Cause:
overlay-fix.csssets a darkbackground-coloron#player-controls button.icon-button,.ytmMuteButtonButtonand.ytmClosedCaptioningButtonButton. Those are square 48px hit areas withborder-radius: 0. Only the play button has its own round shape.Fix, embed selectors only:
The lighter band across the middle of the video is the existing top/bottom gradient (clear in the middle by design). This PR does not change it.
Screenshots
Real YouTube embed in a local iframe page, headed Chromium, default settings. Before (2.2.2) on the left, this PR on the right:
This PR with default settings (left) and with yellow highlight and Clear controls (right):
Testing
npm run check(49 tests) andnpm run smokepass.button.icon-button svg pathmatched two buttons after the fixture change.Link to Devin session: https://app.devin.ai/sessions/ef68d30f1eba41589b2f4c6b1ef98aea
Open in Devin Desktop: https://app.devin.ai/desktop/session/ef68d30f1eba41589b2f4c6b1ef98aea?variant=devin
Requested by: @dzienisz