This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Complete implementation in Swift and add some unit tests #274
Open
KenziTrader
wants to merge
9
commits into
dzenbot:v2-swift
Choose a base branch
from
KenziTrader:v2-swift
base: v2-swift
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctionView.reloadData, UICollectionView.performBatchUpdates(_:completion:)
Conform UITableView and UICollectionView to EmptyDataSet protocol
Add some unit tests
Add unit tests
I made some more additions.
|
KenziTrader
changed the title
Update to Swift 3 and remove most calls to respondsToSelector
Complete implementation in Swift and add some unit tests
Jun 22, 2016
This is great. Thanks a lot @KenziTrader! |
hey, So what's happened ? :) |
Hi, as a newbie to iOS dev, this is one of those, that is a must-have for my current app and probably for future apps. Apologies, that I'm not yet a contributor but only a passive user. But, will you be able to let me know about the developments? Is it ready for swift 3? Many thanks for your efforts and time. :) |
@dzenbot Are there any news on this? I would love to see this soon. It's been almost half a year... |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated to Swift 3 syntax. It still compiles under Swift 2.
Most of the calls to respondsToSelector were replaced by optional chaining. No need to check if it responds to selector.