Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add extra conn params to SQLServer #1097

Open
wants to merge 4 commits into
base: 2.0
Choose a base branch
from

Conversation

trymzet
Copy link
Contributor

@trymzet trymzet commented Oct 22, 2024

Summary

Importance

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

Do not connect during initialization but only when it's needed.
This is required as we now use MSSQL driver v18, which uses newer OpenSSL version, and this new OpenSSL downgraded the security level of SHA1, MD5, SSL 3, TLS 1.0, and TLS 1.1 from 1 to 0, which means we need to lower the bar to connect to archaic, insecure servers. See https://stackoverflow.com/a/72529820/8524524.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant