feat: rework tool calling#753
Open
maksymbuleshnyi wants to merge 15 commits into
Open
Conversation
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1e2e9b1. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
High Risk
Touches core agent LLM invocation, tool schema generation, multi-provider strict transforms, and streaming parsers—behavior changes for all inference modes and can alter model outputs and tool validation.
Overview
This PR reworks agent tool calling end-to-end: schemas, provider transforms, parsing, and streaming alignment.
Schemas & prompts: Structured-output
action_inputis now a JSON object (finish uses{"answer": "..."}); generator-levelstrictflags are removed in favor of per-provider handling. ReAct/XML prompts add stricter single-turn rules; function-calling loops default totool_choice: requiredwhen tools are present (unless overridden).Provider strict mode:
BaseLLM.strict_tools(bool or allowlist) drivestransform_tool_schemason OpenAI and Anthropic—schema cleaning, optional→nullable encoding, free-formdictfields as JSON strings, andstrict: truewhere supported. Anthropic adds LiteLLM patching to forwardstrictand caps strict tools per request.Agent post-processing: After tool calls, inputs are coerced (stringified dicts, including nested models) and protocol nulls stripped before Pydantic validation; truncated tool JSON can be repaired via
repair_truncated_json. Structured-outputfinishreadsaction_input["answer"]when present.Streaming: Structured-output initialization avoids locking onto the raw
action_inputobject for answers (fixes leaking{"answer": ...}in streams); integration FSM assertions account for strict null defaults in streamed tool input.Reviewed by Cursor Bugbot for commit 6f4e213. Bugbot is set up for automated code reviews on this repo. Configure here.