Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ def validators(self) -> Sequence[validation.DataValidator]:
"precipitation_pass_1_surface",
"precipitation_pass_2_surface",
]
radar_only_var = ["precipitation_radar_only_surface"]
return (
partial(
validation.check_analysis_current_data,
Expand All @@ -71,7 +72,7 @@ def validators(self) -> Sequence[validation.DataValidator]:
# categorical (PrecipFlag) is radar-derived with no gauge latency, similar coverage to radar_only.
max_nan_percentage=35,
spatial_sampling="quarter",
exclude_vars=gauge_latency_vars,
exclude_vars=gauge_latency_vars + radar_only_var,
),
partial(
validation.check_analysis_recent_nans,
Expand All @@ -82,4 +83,13 @@ def validators(self) -> Sequence[validation.DataValidator]:
spatial_sampling="quarter",
include_vars=gauge_latency_vars,
),
partial(
validation.check_analysis_recent_nans,
max_expected_delay=max_expected_delay,
# Radar only is ~%34 nan always. With quarter sampling this can get as high as 62.2%.
# It is available at all timestamps.
max_nan_percentage=63,
spatial_sampling="quarter",
include_vars=radar_only_var,
),
)
Original file line number Diff line number Diff line change
Expand Up @@ -216,5 +216,5 @@ def test_operational_kubernetes_resources(

def test_validators(dataset: NoaaMrmsConusAnalysisHourlyDataset) -> None:
validators = tuple(dataset.validators())
assert len(validators) == 3
assert len(validators) == 4
assert all(isinstance(v, validation.DataValidator) for v in validators)