Fix ~2x peak memory in _read_into_data_array by clearing Future._result#477
Merged
Fix ~2x peak memory in _read_into_data_array by clearing Future._result#477
Conversation
concurrent.futures.as_completed holds an internal set of all futures for the duration of iteration. Each Future retains its _result (the numpy array from read_data) even after .result() is called. Since the sum of all read results equals the shared buffer size, this doubles peak memory. Clear future._result immediately after copying data into the shared memory buffer. Verified this reduces peak from ~X to ~0.1X above baseline (where X = shared buffer size). https://claude.ai/code/session_01AzdTz8SLnEW4jSUPV2prJ9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concurrent.futures.as_completed holds an internal set of all futures for
the duration of iteration. Each Future retains its _result (the numpy
array from read_data) even after .result() is called. Since the sum of
all read results equals the shared buffer size, this doubles peak memory.
Clear future._result immediately after copying data into the shared
memory buffer. Verified this reduces peak from ~X to ~0.1X above
baseline (where X = shared buffer size).
https://claude.ai/code/session_01AzdTz8SLnEW4jSUPV2prJ9