Optimize AIFS deterministic forecast chunk/shard layout and fix metadata#474
Closed
mrshll wants to merge 1 commit intoecmwf-aifsfrom
Closed
Optimize AIFS deterministic forecast chunk/shard layout and fix metadata#474mrshll wants to merge 1 commit intoecmwf-aifsfrom
mrshll wants to merge 1 commit intoecmwf-aifsfrom
Conversation
- Fix chunk/shard sizes: 1 init_time per chunk/shard, larger spatial chunks (240x240) per chunk_shard_size tool output - Make precipitable_water_atmosphere metadata consistent across datasets (short_name=pwat, long_name=Precipitable water) and remove stale CF compliance exceptions - Restructure dataset_integration_guide.md: remove ECMWF-specific examples, revert chunk/shard docs to simple wording, simplify storage config section, remove pre-submission checks (duplicate of AGENTS.md) - Use np.testing.assert_allclose in integration test and add post-update snapshot values for temperature_2m and precipitation_rate_surface - Remove ecmwf-api-client dev dependency and scripts ruff ignore rules - Regenerate zarr template https://claude.ai/code/session_01C5o4hepUqwYHeEeYk5rqjy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the Zarr chunk and shard layout for the ECMWF AIFS deterministic forecast dataset and corrects variable metadata to align with CF conventions and dataset naming standards.
Key Changes
Chunk and Shard Optimization:
init_timechunks from 4 to 1 (one initialization per shard, per forecast dataset best practices)Metadata Corrections:
ecmwf-aifs-deterministic-forecast-15-day-0-25-degreetoecmwf-aifs-deterministic-forecast(removes redundant resolution/duration info)ECMWF AIFS deterministic forecast(lowercase, removed resolution/duration)precipitable_water_atmospherevariable metadata:short_namefromtcw(Total Column Water) topwat(Precipitable Water)long_namefromTotal column watertoPrecipitable waterTest Updates:
dynamical_dataset_test.pyto usenp.testing.assert_allclose()for floating-point comparisonsDocumentation:
Dependency Changes:
ecmwf-api-clientdependency from dev requirementsImplementation Details
The chunk/shard optimization was guided by the chunk/shard layout tool to achieve better compression ratios while maintaining efficient access patterns. The metadata corrections ensure consistency across the dataset repository and proper CF compliance.
https://claude.ai/code/session_01C5o4hepUqwYHeEeYk5rqjy