Skip to content

Conversation

@anhductn2001
Copy link
Contributor

PR Standards

Close #1423

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • Included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case PR targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@anhductn2001 anhductn2001 requested a review from a team as a code owner December 12, 2025 04:02
@anhductn2001
Copy link
Contributor Author

Do you think this fallback to the latest height is okay? @srene

Copy link
Collaborator

@artemijspavlovs artemijspavlovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not the latest that should be retrieved,
the way it should work is - retrieve first state update from hub, extract the da height that it was submitted on ( there already are utility functions/methods for that in roller ) and use that height.

if the da client needs even earlier data, for whatever reason - roller, most likely should extract the required height, update da light client config and restart the da client so it syncs the necessary heights

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unable to sync from DA celestia rollapp

2 participants