feat: add validate rpc when setup relayer#1409
Open
anhductn2001 wants to merge 2 commits intomainfrom
Open
Conversation
artemijspavlovs
requested changes
Nov 3, 2025
cmd/relayer/setup/setup.go
Outdated
| case strings.HasPrefix(endpoint, "http://"), strings.HasPrefix(endpoint, "https://"): | ||
| return endpoint | ||
| default: | ||
| return "http://" + endpoint |
Collaborator
There was a problem hiding this comment.
the default should be https endpoint, otherwise the http will try to point to port 80, which is not where anything runs.
cmd/relayer/setup/setup.go
Outdated
| } `json:"result"` | ||
| } | ||
|
|
||
| func validateRollappRPCEndpoint(rollappID, endpoint string) (string, error) { |
Collaborator
There was a problem hiding this comment.
so this checks that the on chain rpc endpoint, provided by the sequencer is actually pointing to the correct chain id?
move it to utils/sequencer, other then that - lgtm
Contributor
Author
There was a problem hiding this comment.
yea thx @artemijspavlovs . I pushed a fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Standards
Close #1366
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: