Fix for xml processing instructions #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2016 23:17
…structions so that the user does not have to manually replace the '/' with '?'. https://www.w3.org/TR/xml11/#dt-pi
Author
|
Any reason this hasn't been merged yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all XML processing instructions begin with a '?' in their name, I modified xml#format to use a '?' instead of a '/' when closing a tag. This also means that xml#addXmlDeclaration no longer needs to manually replace the trailing '/' for the xml declaration.
https://www.w3.org/TR/xml11/#sec-pi
Fixes #35