feat: swap icy webhook

[quanghuynguyen1902]

What's this PR do?

• [wip] swap icy webhook

• Flow

• Message discord

[huynguyenh]

PR Review Summary

I've reviewed the changes for implementing the ICY to BTC swap functionality and webhook. The implementation looks promising but there are several items that should be addressed before merging:

Strengths

• Good database schema design with proper migration script
• Clean contract binding implementation
• Configuration changes follow existing patterns

Areas for Improvement

1. Database Indexing: Consider adding indexes to the new icy_swap_btc_requests table for columns that will be frequently queried:

   CREATE INDEX idx_icy_swap_btc_profile_id ON icy_swap_btc_requests(profile_id);
   CREATE INDEX idx_icy_swap_btc_request_code ON icy_swap_btc_requests(request_code);

2. Configuration Documentation: The new configuration values should be documented:

   • What is the expected format for ICY_BACKEND_PRIVATE_KEY?
   • Should we add examples in the README or .env.example file?

3. Naming Consistency: The change from "swap" to "icyswapbtc" in the transaction action type is good for clarity, but ensure this is applied consistently across the entire codebase to prevent runtime errors.

4. Missing Core Implementation: The webhook controller implementation files don't appear in the PR changes. Please ensure all necessary files are included.

5. Testing: No test files are included - recommend adding at least integration tests for the swap workflow.

6. Error Handling: For blockchain operations, especially around token transfers, robust error handling is critical.

7. Security: Since this involves financial transactions:

   • Validate all input parameters thoroughly
   • Implement proper authentication for webhook endpoints
   • Consider rate limiting to prevent abuse

Overall, this is a good start but needs additional work before it's ready to merge. Please address these items and feel free to reach out if you need clarification on any points.

[huynguyenh]

I'm requesting changes for the following reasons:

1. Database Schema Improvements Needed:

   • Consider adding indexes for frequently queried columns such as profile_id and request_code to improve query performance:

   CREATE INDEX idx_icy_swap_btc_profile_id ON icy_swap_btc_requests(profile_id);
   CREATE INDEX idx_icy_swap_btc_request_code ON icy_swap_btc_requests(request_code);

2. Configuration Documentation Missing:

   • The new config values added in pkg/config/config.go need documentation about their purpose and format
   • Consider adding examples to the README or .env.example file

3. API Consistency Concerns:

   • The change from "swap" to "icyswapbtc" in transaction actions is significant
   • Ensure this is applied consistently across the entire codebase to prevent runtime errors

4. Contract Interface Issues:

   • In pkg/contracts/icyswap/icyswap.go, the function signature comments still reference "swap" while the code calls "icyswapbtc"
   • These should be updated to match for clarity

5. Missing Implementation:

   • The webhook controller implementation files don't appear in the PR changes
   • Please ensure all necessary files are included

6. Testing Strategy:

   • Add at least integration tests for the swap workflow to ensure reliability

Please address these issues before the PR is ready for merging.

[huynguyenh]

First issue regarding the database schema.

[huynguyenh]

Consider adding indexes for frequently queried columns such as profile_id and request_code to improve query performance:

CREATE INDEX idx_icy_swap_btc_profile_id ON icy_swap_btc_requests(profile_id);
CREATE INDEX idx_icy_swap_btc_request_code ON icy_swap_btc_requests(request_code);

[huynguyenh]

I have several specific issues to address:

1. Database Schema (migrations/schemas/20250320153030-create-icy_btc_swap_request.sql):
   Consider adding indexes for frequently queried columns such as profile_id and request_code to improve query performance:

   CREATE INDEX idx_icy_swap_btc_profile_id ON icy_swap_btc_requests(profile_id);
   CREATE INDEX idx_icy_swap_btc_request_code ON icy_swap_btc_requests(request_code);

2. Configuration (pkg/config/config.go):
   Please document the expected format and purpose of these new configuration values for IcyBackend and expanded MochiPay configuration. Also consider adding examples to the README or .env.example file.

3. API Consistency (pkg/service/mochipay/request.go):
   The change from "swap" to "icyswapbtc" in transaction actions is significant. Ensure this is applied consistently across the entire codebase to prevent runtime errors.

4. Contract Documentation (pkg/contracts/icyswap/icyswap.go):
   The function signature comments don't match the actual implementation. The comments still reference "swap" while the code calls "icyswapbtc". These should be updated to match for clarity.

5. Missing Implementation:
   The webhook controller implementation files don't appear in the PR changes. Please ensure all necessary files are included.

6. Testing Strategy:
   Add integration tests for the swap workflow to ensure reliability.