Drop the ADR-017 aliases from edge and docs - #1198
Merged
Merged
Conversation
The homelab half of the ADR-017 contract step, shipping with payment-service v2.8.0 and shipping-service v1.10.0, which remove the aliases in-service. Both edges stop matching the pre-v3 /payment/v1/public/webhooks path. e2e-audit A7 and the k6 smoke suite now expect the shipping alias to answer 404, so a forgotten alias fails the gate instead of passing it. docs/api records the removals and drops the aliases from the known gaps.
The ADR-017 contract releases, which remove the expand-phase aliases in-service. Both passed the full local-stack release audit from scratch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is the homelab half of the ADR-017 contract step, plus the Kind pins for the contract releases. The in-service removals are duynhlab/payment-service#137 (v2.8.0) and duynhlab/shipping-service#212 (v1.10.0), both merged and tagged.
/payment/v1/public/webhooksprefix. mockpay already posts to…/payments/webhooks/mockpaykubernetes/infra/configs/envoy-gateway/routes/api.yaml,local-stack/gateway/eg/routes.yamllocal-stack/docs/e2e-audit.md,scripts/k6/smoke.jsdocs/api/{payments,shipping,microservices}.md2.7.0 → 2.8.0, shipping1.9.1 → 1.10.0kubernetes/apps/services/{payment,shipping}.yaml,mockpay.yamlCHANGELOG.mdRelease gate (passed)
The full local-stack E2E release audit ran from scratch on payment
14c1614and shippingd2a85ce, using this branch's runbook and k6:expired | timerremoved alias is 404Direct checks:
payment/v1/protected/attempts/open,/protected/reconciliations/runs,/public/webhooks/mockpay(at the edge) andshipping/v1/public/estimate.Both tags carry a signed image, a clean Trivy scan and a GitHub Release.
Verified on Kind (branch overlay; main, including #1197's ClusterConnection, merged in)
api-payment-webhooksmatches only/payment/v1/public/payments/webhooks.make e2e GATE=kind: A17–A22, K4.1–K4.8, K5.2–K5.9 and SG.1–SG.4 all PASS.gateway.duynh.me:/shipping/v1/public/track404,/shipments/track200,POST /payment/v1/public/webhooks/mockpay404.ClusterConnection temporal-mopis intact.make validatepasses. After merge, runmake flux-pushfrom main.