chore(go-check): default golangci-lint to v2.14.0 - #132
Merged
Merged
Conversation
v2.12.2 cannot lint code whose go directive is 1.27; go1.27 support landed in v2.13.0. v2.14.0 reports 0 findings on all ten services and the twelve pkg modules today, so the fallback can move ahead of the Go 1.27.1 rollout (homelab#1107 G2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback
lint-version(used by every caller withouttools/go.mod, i.e. the whole fleet) moves from v2.12.2 to v2.14.0. v2.12.2 cannot lint a module whosegodirective is 1.27; go1.27 support landed in v2.13.0.Checked before changing: v2.14.0 reports 0 findings on all 10 services (own
.golangci.yml+ the fleet policy) and on all 12pkgmodules, on today's code. The install step isgo install, so the binary is built with the caller's Go fromgo.mod.First step of the Go 1.27.1 rollout (homelab#1107 G2).
actionlintclean.