NR UE: add assert for reserved bits per symbol not multiple of Qm#258
Open
alexjiao2021 wants to merge 1 commit into
Open
NR UE: add assert for reserved bits per symbol not multiple of Qm#258alexjiao2021 wants to merge 1 commit into
alexjiao2021 wants to merge 1 commit into
Conversation
map_overlapped_ack() divides num_reserved_bits_on_sym by Qm to get the number of reserved REs. Add assertion to catch cases where the reserved bit count is not a multiple of Qm, which would indicate a bug in the upstream UCI-on-PUSCH mapping. Signed-off-by: Alex Jiao <alex.jiao@keysight.com>
Collaborator
|
CI Build: #597 | Not performing CI due to the absence of one of the following mandatory labels:
|
alexjiao2021
added
the
nrUE
Collaborator
|
CI Build: #598 | Failed on the following stages: |
rorsc
approved these changes
Jul 2, 2026
rorsc
added a commit
that referenced
this pull request
Jul 2, 2026
…integration_2026_w27 NR UE: add assert for reserved bits per symbol not multiple of Qm (#258) map_overlapped_ack() divides num_reserved_bits_on_sym by Qm to get the number of reserved REs. Add assertion to catch cases where the reserved bit count is not a multiple of Qm, which would indicate a bug in the upstream UCI-on-PUSCH mapping. This is a follow-up of comment after PR #221 Reviewed-by: Robert Schmidt <robert.schmidt@openairinterface.org>
Collaborator
|
CI Build: #625 | Failed on the following stages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map_overlapped_ack()dividesnum_reserved_bits_on_symbyQmto get the number of reserved REs. Add assertion to catch cases where the reserved bit count is not a multiple ofQm, which would indicate a bug in the upstream UCI-on-PUSCH mapping.This is a follow-up of comment here