fix(zmq): Fix clang compiler warnings in zmq radio#244
Open
bpodrygajlo wants to merge 1 commit into
Open
Conversation
c3f20a0 to
ddc8d7b
Compare
Collaborator
|
CI Build: #554 | Failed on the following stages: |
Collaborator
|
CI Build: #555 | Failed on the following stages: |
rorsc
reviewed
Jun 30, 2026
| const size_t rx_buffer_size = sample_size * 300000; | ||
|
|
||
| typedef struct { | ||
| struct zmq_state_t { |
Member
There was a problem hiding this comment.
I think the original warning (please put it into the description/commit message for reference) was here.
however, you have some additional changes converting a array into a vector. why? it looks ok but I don't understand why. Please also write this into the commit message if possible.
Collaborator
Author
There was a problem hiding this comment.
Clang complained about VLA usage in C++ sources, I'll remove that change.
…inkage) Signed-off-by: Bartosz Podrygajlo <bartosz.podrygajlo@openairinterface.org>
ddc8d7b to
2a3f0ff
Compare
Collaborator
|
CI Build: #589 | Failed on the following stages: |
rorsc
approved these changes
Jul 2, 2026
rorsc
added a commit
that referenced
this pull request
Jul 2, 2026
…ntegration_2026_w27 fix(zmq): Fix clang compiler warnings in zmq radio (#244) Reviewed-by: Robert Schmidt <robert.schmidt@openairinterface.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.