Skip to content

minorfix(imscope): moving alignas from struct type to atomic variable#238

Merged
1 commit merged into
duranta-project:developfrom
turkeryilmaz:minorfix_imscope_psABInote
Jul 4, 2026
Merged

minorfix(imscope): moving alignas from struct type to atomic variable#238
1 commit merged into
duranta-project:developfrom
turkeryilmaz:minorfix_imscope_psABInote

Conversation

@turkeryilmaz

Copy link
Copy Markdown
Contributor

I was receiving the note below when I built with "imscope_record", so this is the simplest PR to avoid the psABI note while signing the new individual CLA.

[194/11156] Building CXX object openair1/PHY/TOOLS/imscope/CMakeFiles/imscope_record.dir/imscope_record.cpp.o
In file included from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/defs_nr_UE.h:12,
from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_internal.h:12,
from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_record.cpp:5:
/usr/include/c++/13/atomic: In member function ‘_Tp std::atomic<_Tp>::exchange(_Tp, std::memory_order) [with _Tp = ImScopeDumpInstruction]’:
/usr/include/c++/13/atomic:311:7: note: the ABI for passing parameters with 64-byte alignment has changed in GCC 4.6
311 | exchange(_Tp __i, memory_order __m = memory_order_seq_cst) noexcept
| ^~~~~~~~

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 26, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: turkeryilmaz / name: Turker Yilmaz (5a963bd)

@durantabot

Copy link
Copy Markdown
Collaborator

CI Build: #495 | Not performing CI due to the absence of one of the following mandatory labels:

  • documentation Documentation-related changes or updates. (don't perform any stages)
  • BUILD-ONLY Execute build stages only for code improvements with no impact on 4G/5G functionality. (execute only build stages)
  • 4G-LTE Perform 4G Tests (perform 4G tests)
  • 5G-NR Perform 5G Tests (perform 5G tests)
  • nrUE Run only 5G UE tests (physims included, LDPC tests excluded). (perform only 5G-UE related tests including physims excluding LDPC tests)
  • CI Perform both 4G and 5G tests (perform both 4G and 5G tests)

@sgarg00 sgarg00 added BUILD-ONLY Execute build stages only for code improvements with no impact on 4G/5G functionality. retrigger-ci Re-run CI and removed retrigger-ci Re-run CI labels Jun 27, 2026
@github-actions github-actions Bot removed the retrigger-ci Re-run CI label Jun 27, 2026
@rorsc rorsc requested a review from bpodrygajlo June 29, 2026 07:29
@rorsc rorsc added this to the OK_TO_BE_MERGED milestone Jun 30, 2026
@rorsc

rorsc commented Jun 30, 2026

Copy link
Copy Markdown
Member

@turkeryilmaz you are missing the signed-off-by commit trailer, please add with git commit -s

@rorsc rorsc mentioned this pull request Jun 30, 2026
… to avoid psABI note

Signed-off-by: Turker Yilmaz <turker87@gmail.com>
@turkeryilmaz turkeryilmaz force-pushed the minorfix_imscope_psABInote branch from 5a963bd to 3dbb22c Compare July 2, 2026 10:49
rorsc added a commit that referenced this pull request Jul 2, 2026
…' into integration_2026_w27

minorfix(imscope): moving alignas from struct type to atomic variable (#238)

I was receiving the note below when I built with "imscope_record", so
this is the simplest PR to avoid the psABI note while signing the new
individual CLA.

    [194/11156] Building CXX object openair1/PHY/TOOLS/imscope/CMakeFiles/imscope_record.dir/imscope_record.cpp.o
    In file included from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/defs_nr_UE.h:12,
    from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_internal.h:12,
    from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_record.cpp:5:
    /usr/include/c++/13/atomic: In member function ‘_Tp std::atomic<_Tp>::exchange(_Tp, std::memory_order) [with _Tp = ImScopeDumpInstruction]’:
    /usr/include/c++/13/atomic:311:7: note: the ABI for passing parameters with 64-byte alignment has changed in GCC 4.6
    311 | exchange(_Tp __i, memory_order __m = memory_order_seq_cst) noexcept
    | ^~~~~~~~

Reviewed-by: Bartosz Podrygajlo <bartosz.podrygajlo@openairinterface.org>
rorsc added a commit that referenced this pull request Jul 2, 2026
…' into integration_2026_w27

minorfix(imscope): moving alignas from struct type to atomic variable (#238)

I was receiving the note below when I built with "imscope_record", so
this is the simplest PR to avoid the psABI note while signing the new
individual CLA.

    [194/11156] Building CXX object openair1/PHY/TOOLS/imscope/CMakeFiles/imscope_record.dir/imscope_record.cpp.o
    In file included from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/defs_nr_UE.h:12,
    from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_internal.h:12,
    from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_record.cpp:5:
    /usr/include/c++/13/atomic: In member function ‘_Tp std::atomic<_Tp>::exchange(_Tp, std::memory_order) [with _Tp = ImScopeDumpInstruction]’:
    /usr/include/c++/13/atomic:311:7: note: the ABI for passing parameters with 64-byte alignment has changed in GCC 4.6
    311 | exchange(_Tp __i, memory_order __m = memory_order_seq_cst) noexcept
    | ^~~~~~~~

Reviewed-by: Bartosz Podrygajlo <bartosz.podrygajlo@openairinterface.org>
@rorsc rorsc closed this pull request by merging all changes into duranta-project:develop in 0dab3bb Jul 4, 2026
@turkeryilmaz turkeryilmaz deleted the minorfix_imscope_psABInote branch July 4, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BUILD-ONLY Execute build stages only for code improvements with no impact on 4G/5G functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants