minorfix(imscope): moving alignas from struct type to atomic variable#238
Merged
1 commit merged intoJul 4, 2026
Merged
Conversation
|
|
Collaborator
|
CI Build: #495 | Not performing CI due to the absence of one of the following mandatory labels:
|
bpodrygajlo
approved these changes
Jun 29, 2026
Member
|
@turkeryilmaz you are missing the signed-off-by commit trailer, please add with |
Merged
… to avoid psABI note Signed-off-by: Turker Yilmaz <turker87@gmail.com>
5a963bd to
3dbb22c
Compare
rorsc
added a commit
that referenced
this pull request
Jul 2, 2026
…' into integration_2026_w27 minorfix(imscope): moving alignas from struct type to atomic variable (#238) I was receiving the note below when I built with "imscope_record", so this is the simplest PR to avoid the psABI note while signing the new individual CLA. [194/11156] Building CXX object openair1/PHY/TOOLS/imscope/CMakeFiles/imscope_record.dir/imscope_record.cpp.o In file included from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/defs_nr_UE.h:12, from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_internal.h:12, from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_record.cpp:5: /usr/include/c++/13/atomic: In member function ‘_Tp std::atomic<_Tp>::exchange(_Tp, std::memory_order) [with _Tp = ImScopeDumpInstruction]’: /usr/include/c++/13/atomic:311:7: note: the ABI for passing parameters with 64-byte alignment has changed in GCC 4.6 311 | exchange(_Tp __i, memory_order __m = memory_order_seq_cst) noexcept | ^~~~~~~~ Reviewed-by: Bartosz Podrygajlo <bartosz.podrygajlo@openairinterface.org>
rorsc
added a commit
that referenced
this pull request
Jul 2, 2026
…' into integration_2026_w27 minorfix(imscope): moving alignas from struct type to atomic variable (#238) I was receiving the note below when I built with "imscope_record", so this is the simplest PR to avoid the psABI note while signing the new individual CLA. [194/11156] Building CXX object openair1/PHY/TOOLS/imscope/CMakeFiles/imscope_record.dir/imscope_record.cpp.o In file included from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/defs_nr_UE.h:12, from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_internal.h:12, from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_record.cpp:5: /usr/include/c++/13/atomic: In member function ‘_Tp std::atomic<_Tp>::exchange(_Tp, std::memory_order) [with _Tp = ImScopeDumpInstruction]’: /usr/include/c++/13/atomic:311:7: note: the ABI for passing parameters with 64-byte alignment has changed in GCC 4.6 311 | exchange(_Tp __i, memory_order __m = memory_order_seq_cst) noexcept | ^~~~~~~~ Reviewed-by: Bartosz Podrygajlo <bartosz.podrygajlo@openairinterface.org>
0dab3bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was receiving the note below when I built with "imscope_record", so this is the simplest PR to avoid the psABI note while signing the new individual CLA.
[194/11156] Building CXX object openair1/PHY/TOOLS/imscope/CMakeFiles/imscope_record.dir/imscope_record.cpp.o
In file included from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/defs_nr_UE.h:12,
from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_internal.h:12,
from /home/turker/Documents/OpenAirInterface/26w25/openair1/PHY/TOOLS/imscope/imscope_record.cpp:5:
/usr/include/c++/13/atomic: In member function ‘_Tp std::atomic<_Tp>::exchange(_Tp, std::memory_order) [with _Tp = ImScopeDumpInstruction]’:
/usr/include/c++/13/atomic:311:7: note: the ABI for passing parameters with 64-byte alignment has changed in GCC 4.6
311 | exchange(_Tp __i, memory_order __m = memory_order_seq_cst) noexcept
| ^~~~~~~~