Separate NR from LTE#229
Conversation
Signed-off-by: Francesco Mani <email@francescomani.it>
fh_if4p5_south_in and fh_if4p5_south_out are called in NR for 7.2 split but never actually executed they are overwritten at runtime in ru_thread Signed-off-by: Francesco Mani <email@francescomani.it>
…for NR
Create nr_fhi_t *fhi in openair0_device_t (rfdevice for LOCAL_RF,
ifdevice for IF5/IF4p5), keeping split logic out of the L1 struct.
LOCAL_RF used for rfsimulator and USRP.
For REMOTE_IF4p5, nr_fhi_if4p5_dl_slot_send now calls ru->fh_south_out after
get_internal_parameter("fh_if4p5_south_out") overwrites fh_south_out.
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
|
CI Build: #447 | Failed on the following stages: |
|
CI Build: #446 | Failed on the following stages: |
…_if5_south_out to AW2S Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
…_if5_south_in to AW2S Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
|
CI Build: #457 | Failed on the following stages: |
…ng init_NR_RU() Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
… for NR Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
…t_NR_RU() Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
…pendant Move stopping and ending RF/IF devices from nr-softmodem.c to nr-ru.c RU_t dependency function pointers: - feprx - start_rf - stop_rf - start_write_thread - nr_start_if Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org>
Signed-off-by: Teodora Vladić <teodora.vladic@openairinterface.org> Fixes: 7b7afae ("feat(oran_fhlib_5g): Changes to run K release)"
|
CI Build: #488 | Failed on the following stages: |
|
It would be better to use established terms in names and use existing architectures as the base of this work. I don't know about AW2S or legacy LTE radios, but what you are describing here is a lower-layer split, specifically a family of 7.x splits. To me this does not necessarily fit the I think it would be best if the name was related to LLS / Split7.x. We should also drop all names like if5, if4.5 as these are historical synonyms to the now industry-standard split8/split7 nomenclature. The entire integration layer should be inside the application instead of the openair0_device. Accesses to RU_t and gNB_t just make the code more difficult to understand inside the libraries. One thing that is missing is the 7.2 extensions related to beamforming and precoding. We should identify these extensions and add them to the interface. An example is of these extensions are seen here: https://gitlab.eurecom.fr/oai/openairinterface5g/-/merge_requests/4016. |
Thanks @bpodrygajlo. I will delete if5/if4p5 naming. I just need to do step by step to make sure that CI is unaffected with my cleanup. But yes, I completely agree it's outdated. I want to completely remove NR dependency on I am aware for precoding and beamforming, that I still have to do. At the moment, we use |
"Split handling" means LLS/7.2/frequency domain? can you please say why you would like to use openair0 for frequency domain, please? I agree with Bartosz in that this seems to be made for time-domain signals, and that at least for 7.2, people crammed it there because they did not know where to put it, not because that was the best choice. |
Yes, I want a device to take care of all LLS (time and frequency domain) splits. Since initially, 7.2 is designed to use My main goals would be to:
That would be it for now, and then I need to figure out the sync time for 7.2 (because I would like to remove |
Not yet finished.
I need CI results for all pipelines in order to continue reworking NR APIs.