fix(NR_UE): gate half-frame PBCH mirror on caller-provided ssb_period#220
Merged
1 commit merged intoJul 4, 2026
Conversation
is_ssb_in_symbol() read cfg->ssb_table.ssb_period directly, but before the FAPI PHY config request arrives (received_config_request == false) that field is still 0, which it interprets as a 5ms period and enables the half-frame PBCH mirror. get_ssb_index_in_symbol() already assumes the 20ms default period for its frame-periodicity test, so the two disagree and the UE attempts a spurious PBCH decode in the second half-frame (slot 5 for mu=0) before being configured. Closes: duranta-project#219 Signed-off-by: ChrisAB <cristianbatrin@gmail.com>
Collaborator
|
CI Build: #416 | Not performing CI due to the absence of one of the following mandatory labels:
|
francescomani
added
the
nrUE
francescomani
approved these changes
Jun 23, 2026
francescomani
approved these changes
Jun 23, 2026
Contributor
Author
|
Hello @francescomani , thanks for the approve. I see though CI is still failing on label step, is there anything more that needs to be done from my side? |
Collaborator
|
CI Build: #448 | Failed on the following stages: |
Merged
Member
replays:
|
rorsc
added a commit
that referenced
this pull request
Jul 2, 2026
…phy_config' into integration_2026_w27 fix(NR_UE): gate half-frame PBCH mirror on caller-provided ssb_period (#220) is_ssb_in_symbol() read cfg->ssb_table.ssb_period directly, but before the FAPI PHY config request arrives (received_config_request == false) that field is still 0, which it interprets as a 5ms period and enables the half-frame PBCH mirror. get_ssb_index_in_symbol() already assumes the 20ms default period for its frame-periodicity test, so the two disagree and the UE attempts a spurious PBCH decode in the second half-frame (slot 5 for mu=0) before being configured. Closes: #219 Reviewed-by: Francesco Mani <email@francescomani.it>
rorsc
closed this pull request by merging all changes
into
duranta-project:develop
in
0dab3bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_ssb_in_symbol() read cfg->ssb_table.ssb_period directly, but before the FAPI PHY config request arrives (received_config_request == false) that field is still 0, which it interprets as a 5ms period and enables the half-frame PBCH mirror. get_ssb_index_in_symbol() already assumes the 20ms default period for its frame-periodicity test, so the two disagree and the UE attempts a spurious PBCH decode in the second half-frame (slot 5 for mu=0) before being configured.
Closes: #219