Skip to content

Keep activity entry-safety tests scoped to their original run - #917

Merged
rmcdaniel merged 3 commits into
mainfrom
fix/898-activity-entry-fixture-scope
Oct 23, 2026
Merged

rmcdaniel merged 3 commits into
mainfrom
fix/898-activity-entry-fixture-scope

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

The full MySQL source suite fails before its activity entry-safety assertions: the fixture looks up ready workflow tasks globally and collides with a run left by an earlier database-truncation fixture. The isolated cases pass, which hid the dependency on test order.

Scope task, execution, history and repair-count checks to the original run. Add a control with another valid ready run and verify that its task and history remain unchanged while the target run still refuses the incompatible activity and records its original failure. All existing entry-safety assertions, retry expectations and runtime source are retained.

Evidence:

  • Original main run 39980005341 / job 120505667716 has exactly eight MultipleRecordsFoundException errors in this helper, independently read from its digest-verified retained JUnit archive by temporary diagnostic run 39987095094. No original test rerun or default-branch diagnostic code was used; its temporary branch is removed.
  • Test-first c1117d9 adds the unrelated-run case: one collision error and eight existing cases passing on actual MySQL 8.0.46.
  • Corrected codec-prefix plus entry-safety selection: 11 tests / 72 assertions pass on actual MySQL, preserving the original guard checks and the foreign run. Final formatted-source verification independently passes the same 11 / 72; full PHPStan source/tests passes.
  • Focused ECS passes. The separate local deadlock control passes 8 / 180 after restoring the performance_schema capability its fixture requires. Its earlier seven local failures were an incorrect diagnostic service setup, not a product-fix claim.

Refs #898. The already merged timeline correction is also included in the pending 2.12.0 changelog section, with no version change. The functional correction is test-only: no runtime, API, schema, dependency, version, native/shared/frozen or release-policy change. Fresh normal checks and publication remain required.

@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel marked this pull request as ready for review October 23, 2026 17:20
@rmcdaniel
rmcdaniel merged commit 789f3b6 into main Oct 23, 2026
22 checks passed
@rmcdaniel
rmcdaniel deleted the fix/898-activity-entry-fixture-scope branch October 23, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant