Repository navigation
Deliver unpinned activities during versioned rollouts - #909
Merged
Merged
Conversation
|
rmcdaniel
marked this pull request as ready for review
October 23, 2026 05:00
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Changes
Addresses #908. Activity polls from a versioned worker now include unpinned
tasks as well as tasks pinned to that worker's build. The grouped predicate
preserves namespace, queue, connection, task type, activity type, readiness and
availability constraints. Existing claim validation keeps its original run,
execution, attempt and lease authority.
Prepare compatible patch 2.11.2. No dependency constraint, schema or worker
protocol changes. Native/shared/frozen fixtures remain independently qualified.
Evidence
The test-first commit 12f57cc produces five failures on unchanged production
source, with two existing controls passing. All four null/empty-pin and
first/second-build cases miss their task; the scoped poll sees only the pinned
task. The corrected source passes all seven cases with 58 assertions.
The complete activity-bridge class passes independently on actual SQLite,
PostgreSQL 17.11 and MySQL 8.0.46: 68 tests and 412 assertions on each, with
no skips. PDO driver and network server versions are verified. This uses the
existing class under an isolated unit harness, without queue-worker processes.
Changed-file ECS and PHPStan pass. Normal Composer
2.10.3 installation on PHP 8.3.36 resolves Laravel 13.38.0, Testbench 11.3.0
and PHPUnit 12.5.40 using the verified public CA paths. The first setup attempt
refused a missing expected bundle hash; the corrected runner supplies the
already-reviewed digest without changing the verifier or TLS behavior.
Final candidate
0b38e2dad24fb231782e5fa6166442d295e61513/ whole579372329eb58d34aed5fa7b4d071fc51479d10fpasses all 17 applicable checks,with six explicit skips. Sonar passes and its issue API has zero OPEN or
CONFIRMED issues. The earlier b14 quality job failed only on the layout of a
new fixture's
now()chain. The final style-only correction preserves theproduction file and test assertions; that original failure stays recorded.
Publication and installed Server acceptance remain pending.
This source result does not fix previously
published images or adopt a native implementation.