Skip to content

Bootstrap verified pip trust before CI network installs - #907

Merged
rmcdaniel merged 4 commits into
mainfrom
fix/237-ci-bootstrap-trust
Oct 22, 2026
Merged

rmcdaniel merged 4 commits into
mainfrom
fix/237-ci-bootstrap-trust

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Verify pip trust before CI dependency installs

Refs durable-workflow/.github#237. Add the reviewed immutable pip bootstrap before policy dependencies, preserving application runtime, packages, protocol fixtures and job budgets.

The first candidate's unit-contract job failed at SqliteDatabaseAcknowledgementTest::testChangedQueueAndReservationTimestampAreAlsoFenced (522 tests / 2,765 assertions, one failure). Its fixture computes time()+1 before creating the reservation. If the clock advances, the supposed replacement timestamp can equal the newly reserved timestamp, so valid deletion fails the fixture's assertion.

A deterministic one-second clock-boundary control reproduces that exact null assertion on the old test. The corrected fixture derives a distinct timestamp from the stored original and verifies the entire changed row survives. It passes the controlled boundary (four assertions) and the full acknowledgement class (14 tests / 78 assertions) on PHP 8.3.36 / Laravel 13.34.0 with the unchanged candidate runtime source. No production queue/fence code changes, retries, handler replay or old-result rescue are included. The original CI remains failed; fresh normal qualification is required.

@rmcdaniel
rmcdaniel marked this pull request as ready for review October 22, 2026 15:21
@rmcdaniel rmcdaniel closed this Oct 22, 2026
@rmcdaniel rmcdaniel reopened this Oct 22, 2026
@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel merged commit 33f556f into main Oct 22, 2026
22 checks passed
@rmcdaniel
rmcdaniel deleted the fix/237-ci-bootstrap-trust branch October 22, 2026 20:08
@rmcdaniel

Copy link
Copy Markdown
Member Author

Delivered through the normal protected merge at 33f556f. Whole tree f18163666ff4e0749965c749d0fbceaecd69a591 exactly matches qualified 32f4046. All 16 applicable checks pass with six explicit skips; the current Sonar report has zero new/accepted issues. Remote branch deletion is verified by the ref API returning 404. This changes CI and the deterministic acknowledgement-test fixture, with no runtime, package version or release change. Existing failed observations remain on their original runs. The separate protected policy issuer and organization rollout remain open under shared #237.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant