Repository navigation
Bootstrap verified pip trust before CI network installs - #907
Merged
Merged
Conversation
rmcdaniel
marked this pull request as ready for review
October 22, 2026 15:21
|
Member
Author
|
Delivered through the normal protected merge at 33f556f. Whole tree f18163666ff4e0749965c749d0fbceaecd69a591 exactly matches qualified 32f4046. All 16 applicable checks pass with six explicit skips; the current Sonar report has zero new/accepted issues. Remote branch deletion is verified by the ref API returning 404. This changes CI and the deterministic acknowledgement-test fixture, with no runtime, package version or release change. Existing failed observations remain on their original runs. The separate protected policy issuer and organization rollout remain open under shared #237. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Verify pip trust before CI dependency installs
Refs durable-workflow/.github#237. Add the reviewed immutable pip bootstrap before policy dependencies, preserving application runtime, packages, protocol fixtures and job budgets.
The first candidate's unit-contract job failed at
SqliteDatabaseAcknowledgementTest::testChangedQueueAndReservationTimestampAreAlsoFenced(522 tests / 2,765 assertions, one failure). Its fixture computestime()+1before creating the reservation. If the clock advances, the supposed replacement timestamp can equal the newly reserved timestamp, so valid deletion fails the fixture's assertion.A deterministic one-second clock-boundary control reproduces that exact null assertion on the old test. The corrected fixture derives a distinct timestamp from the stored original and verifies the entire changed row survives. It passes the controlled boundary (four assertions) and the full acknowledgement class (14 tests / 78 assertions) on PHP 8.3.36 / Laravel 13.34.0 with the unchanged candidate runtime source. No production queue/fence code changes, retries, handler replay or old-result rescue are included. The original CI remains failed; fresh normal qualification is required.