Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ST_DWithin_Spheroid function registration to match implementation #521

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

patrick-orennia
Copy link
Contributor

@patrick-orennia patrick-orennia commented Mar 12, 2025

Description
This PR fixes a mismatch in the registration of the ST_DWithin_Spheroid function (#520). The function implementation expects three parameters (two points and a distance limit) and returns a boolean value, but the registration was incorrectly configured with only two parameters and a DOUBLE return type.

Changes
Added the missing 'distance' parameter of type DOUBLE to the function registration
Changed the return type from DOUBLE to BOOLEAN to correctly match the function implementation
The function now properly checks if two points are within a specified distance using an ellipsoidal model

@Maxxen Maxxen changed the base branch from main to v1.2.0 March 12, 2025 15:42
@Maxxen
Copy link
Member

Maxxen commented Apr 2, 2025

Hi! Thanks a lot for the PR!
Unfortunately we got some CI issues, but I've included your commit in #532 which Im going to try to massage through and merge in the next couple of days!

@Maxxen Maxxen merged commit 9be8381 into duckdb:v1.2.0 Apr 3, 2025
2 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants