Download pre-built DuckDB libraries #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlafeldt
force-pushed
the
download-libduckdb
branch
4 times, most recently
from
7a5427a to
fc81d12
Compare
How this works: When `DUCKDB_DOWNLOAD_LIB` is set, we map `CARGO_TARGET_DIR` to `target/duckdb-download/<target>/<version>`, download the matching DuckDB release archive, unzip it, and extend link-search/rpath to that directory. We also copy the downloaded library into `target/<profile>/deps` so test binaries can load it without extra env vars, matching the `DUCKDB_LIB_DIR` flow. Inspired by - https://github.com/vortex-data/vortex/blob/develop/vortex-duckdb/build.rs - https://github.com/nbigaouette/onnxruntime-rs/blob/master/onnxruntime-sys/build.rs
mlafeldt
force-pushed
the
download-libduckdb
branch
from
97d10f8 to
2d31488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How this works:
When
DUCKDB_DOWNLOAD_LIBis set, we mapCARGO_TARGET_DIRtotarget/duckdb-download/<target>/<version>, download the matching DuckDB release archive, unzip it, and add the directory to the linker search path.We also copy the downloaded library into
target/<profile>/depsso test binaries can load it without extra env vars, matching theDUCKDB_LIB_DIRflow.This will make building much easier - no toolchain to compile DuckDB, or manual downloads and fiddling with
DUCKDB_LIB_DIR, etc.Inspired by