Added union type support in arrow feature #280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swoorup
changed the title
|
Moved to #337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an MVP support for union types for use in appender via arrows.
The insertion works fine currently for primitive and string types (more types can be added in the future).
However the retrieval is failing, possibly due to duckdb/duckdb#11326 ?
ok: CDataInterface("The datatype \"Union([(0, Field { name: \"num\", data_type: Int32, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }), (1, Field { name: \"str\", data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })], Sparse)\" expects 1 buffer, but requested 1. Please verify that the C data interface is correctly implemented.")Thanks @Tishj for giving me pointers.