Skip to content

fix: Fix translation for add_days() and add_years() clock functions #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

IoannaNika
Copy link
Contributor

Splitting PRs as suggested in #643.

In this PR the add_days() and add_years() functions are updated to support variables for the n argument. The issue is described in #643 .

@IoannaNika IoannaNika marked this pull request as ready for review January 8, 2025 10:02
@krlmlr krlmlr changed the base branch from main to cran-1.2.0 February 14, 2025 17:20
@krlmlr krlmlr changed the title Fix add_days() and add_years() clock functions fix: Fix translation for add_days() and add_years() clock functions Feb 14, 2025
@krlmlr krlmlr merged commit 423bdb4 into duckdb:cran-1.2.0 Feb 14, 2025
19 checks passed
@krlmlr
Copy link
Collaborator

krlmlr commented Feb 14, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants