Skip to content

Change the schedule and add a concurrency group to the NightlyBuildsCheck.yml #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

hmeriann
Copy link
Collaborator

Sometimes the NightlyBuildsCheck.yml workflow starts before the InvokeCI completes running.

This PR moves the schedule to be triggered at 11 CEST daily.

We would like to have older runs got cancelled when there is a new run of the NightlyBuildsCheck.yml had been triggered.

This PR adds concurrency group to manage that.

The future work is to make InvokeCI call the NightlyBuildsCheck.yml to avoid running it by the schedule, which can start before the InvokeCI completed.

@hmeriann hmeriann marked this pull request as draft March 14, 2025 12:44
@hmeriann hmeriann marked this pull request as ready for review March 17, 2025 08:52
@hmeriann hmeriann requested a review from carlopi March 17, 2025 09:43
Copy link

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will finish review later, for now I looked at coordination.

@hmeriann
Copy link
Collaborator Author

As discussed with @carlopi , schedule should stay till the workflow run will be triggered by InvokeCI

@carlopi
Copy link

carlopi commented Mar 17, 2025

I think possibly something is off, the pushed code do not looks to be behaving as described.
In particular, cron is now missing.

@carlopi
Copy link

carlopi commented Mar 17, 2025

Also noticing there are many jobs like CI / Build (jekyll gem) (3.9, ubuntu-latest, 3.3) (pull_request), I would guess those can be removed.

@carlopi
Copy link

carlopi commented Mar 17, 2025

Possibly https://github.com/duckdb/duckdb-build-status/blob/main/.github/workflows/ci.yml can be just removed

GH_REPO now is duckdb/duckdb-build-status because it's triggered fron duckdb/duckdb and the repo with the script should be explicitly pointing to the duckdb/duckdb-build-status
chron is back
@hmeriann
Copy link
Collaborator Author

I think possibly something is off, the pushed code do not looks to be behaving as described. In particular, cron is now missing.

Sorry, put it back

@carlopi
Copy link

carlopi commented Mar 17, 2025

This as it's now will not work, I think the cron step needs do be in a separate workflow that then needs to create both a job for main and a job for v1.2-histrionicus.

@hmeriann
Copy link
Collaborator Author

hmeriann commented Mar 17, 2025

There were some more problems which I've just fixed and created a new triggering workflow in another repo to test.

@hmeriann hmeriann force-pushed the main branch 4 times, most recently from da80997 to 854dda9 Compare April 7, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants