-
Notifications
You must be signed in to change notification settings - Fork 2
Change the schedule and add a concurrency group to the NightlyBuildsCheck.yml
#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will finish review later, for now I looked at coordination.
e5b90b1
to
baa2d68
Compare
As discussed with @carlopi , schedule should stay till the workflow run will be triggered by |
I think possibly something is off, the pushed code do not looks to be behaving as described. |
Also noticing there are many jobs like |
Possibly https://github.com/duckdb/duckdb-build-status/blob/main/.github/workflows/ci.yml can be just removed |
GH_REPO now is duckdb/duckdb-build-status because it's triggered fron duckdb/duckdb and the repo with the script should be explicitly pointing to the duckdb/duckdb-build-status chron is back
Sorry, put it back |
This as it's now will not work, I think the cron step needs do be in a separate workflow that then needs to create both a job for |
9815f3b
to
3bd803f
Compare
There were some more problems which I've just fixed and created a new triggering workflow in another repo to test. |
No event if main
…into call-from-invoke
136dbc6
to
d06afa2
Compare
da80997
to
854dda9
Compare
This PR moves the schedule to be triggered at 11 CEST daily.
This PR adds concurrency group to manage that.
The future work is to make
InvokeCI
call theNightlyBuildsCheck.yml
to avoid running it by the schedule, which can start before theInvokeCI
completed.