upgrade cookie_store to 0.21.1 #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kranurag7
commented
Jan 5, 2025
This was referenced Jan 5, 2025
blyxxyz
reviewed
Jan 5, 2025
There was a problem hiding this comment.
This gets rid of 2 dependencies and 5 duplicated dependencies so definitely a nice change, thank you!
I don't think that the CVE is a security concern for us, since we run the hostname through a URL parse before we set it on the cookie and we don't have any crazy authentication system where you can benefit from not matching a domain. So we don't need to rush out another release.
|
@kranurag7 do you mind resolving current merge conflicts? We can fix any clippy warnings after merging this PR |
upgrading cookie_store to 0.21.1 via this commit because it was pulling idna which contained a CVE. Signed-off-by: kranurag7 <[email protected]>
Co-authored-by: Jan Verbeek <[email protected]>
Signed-off-by: kranurag7 <[email protected]> Co-authored-by: Jan Verbeek <[email protected]>
kranurag7
force-pushed
the
kr/upgrade-cookie_store
branch
from
377d86a to
bb82a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading cookie_store to 0.21.1 via this commit because it was pulling idna which contained a CVE.