Skip to content

Commit

Permalink
Switching metrics from port to listen
Browse files Browse the repository at this point in the history
  • Loading branch information
dubo-dubon-duponey committed Feb 24, 2024
1 parent 6b159b1 commit c948e4d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,15 @@ ENV DNS_PORT=53
# ENV DNS_OVER_GRPC_PORT=553
ENV DNS_STUFF_MDNS=false

ENV METRICS_PORT=9253
ENV METRICS_LISTEN=:9253

# NOTE: this will not be updated at runtime and will always EXPOSE default values
# Either way, EXPOSE does not do anything, except function as a documentation helper
EXPOSE $DNS_PORT/udp
EXPOSE $DNS_OVER_TLS_PORT/tcp
EXPOSE $DNS_OVER_TLS_LEGO_PORT/tcp
#EXPOSE $DNS_OVER_GRPC_PORT/tcp
EXPOSE $METRICS_PORT/tcp
EXPOSE $METRICS_LISTEN/tcp

# Lego just needs /certs to work
VOLUME /certs
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ You can also tweak the following:
* DNS_OVER_GRPC_PORT (default to 553)
-->
* DNS_STUFF_MDNS: convenient little trick to respond for certain mDNS queries over traditional DNS
* METRICS_PORT for Prometheuse (default to 9253)
* METRICS_LISTEN for Prometheus (default to :9253)

Of course using any privileged port for these requires CAP_NET_BIND_SERVICE.

Expand Down
2 changes: 1 addition & 1 deletion context/runtime/boot/entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ DNS_PORT="${DNS_PORT:-}"
DNS_STUFF_MDNS="${DNS_STUFF_MDNS:-}"

# Metrics settings
METRICS_PORT="${METRICS_PORT:-}"
METRICS_LISTEN="${METRICS_LISTEN:-}"

certs::renew(){
local domain="$1"
Expand Down
2 changes: 1 addition & 1 deletion context/runtime/config/snips/monitor.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ health localhost:8091
# https://coredns.io/plugins/pprof/
pprof localhost:6053
# https://coredns.io/plugins/metrics/
prometheus :{$METRICS_PORT}
prometheus {$METRICS_LISTEN}
# https://coredns.io/plugins/log/
log
# {combined}
Expand Down

0 comments on commit c948e4d

Please sign in to comment.