fix: /banned Nav and Foooter links go to correct domain
#1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dubinc#1898 `/banned` is unique like [`/app.dub.co/(share)/share/[dashboardId]/page.tsx`](https://github.com/dubinc/dub/blob/main/apps/web/app/app.dub.co/(share)/share/%5BdashboardId%5D/page.tsx) in that it is on a specific domain but does not have a `[domain]` in its path. This means that the `Nav` and `NavMobile` will assume it's on `dub.co` and use links relative to the current domain, when in reality it needs to specify `dub.co`. This is fixed by manually specifying that the domain is not `dub.co` and instead is `dub.sh` with `staticDomain="dub.sh"`
|
@6TELOIV is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Same as previous commit, but for Footer
6TELOIV
changed the title
/banned Nav links go to correct domain/banned Nav and Foooter links go to correct domain
steven-tey
approved these changes
Jan 18, 2025
|
@6TELOIV fantastic analysis and great fix, thank you! Just merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1898
/bannedis unique like/app.dub.co/(share)/share/[dashboardId]/page.tsxin that it is on a specific domain but does not have a[domain]in its path. This means that theNavandNavMobilewill assume it's ondub.coand use links relative to the current domain, when in reality it needs to specifydub.co.This is fixed by manually specifying that the domain is not
dub.coand instead isdub.shwithstaticDomain="dub.sh"