Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save enabled for new tags and update link-preview on url change #1823

Merged

Conversation

Suksham-sharma
Copy link
Contributor

@Suksham-sharma Suksham-sharma commented Dec 21, 2024

This PR addresses two issues in the link-builder modal:

  1. Save Option Not Enabled for New Tags
  • Fixed the issue where adding new tags did not enable the "Save" button.
  • Now, creating new tags in the URL link modal properly enables the "Save" option, allowing users to save their changes.
  1. Link Preview Not Updating
  • Resolved a bug where the link preview was not being updated after it was initially set.
  • Updated the code to ensure that the link preview dynamically reflects any changes made to the associated information.

Changes Made
Adjusted the logic for enabling the "Save" button in response to new tag creation.
Modified the update mechanism for the link preview to ensure it reflects all updates whenever the info is updated

Testing

  • Verified that creating new tags enables the "Save" option.

Earlier:

Screen.Recording.2024-12-20.at.12.10.16.AM.mp4

Fixed:

Screen.Recording.2024-12-20.at.12.36.50.AM.mp4
  • Confirmed that changes to the URL update the link preview as expected.

Earlier:

Screen.Recording.2024-12-22.at.3.04.48.AM.mp4

Fixed:

Screen.Recording.2024-12-22.at.3.06.50.AM.mp4

Resolves #1812
Resolves #1781

Copy link

vercel bot commented Dec 21, 2024

@Suksham-sharma is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@steven-tey steven-tey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a beautiful fix, thank you!

@steven-tey steven-tey merged commit eae0384 into dubinc:main Dec 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants