-
Notifications
You must be signed in to change notification settings - Fork 13
Added route for adding bulk user #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added route for bulk adding users
Shobhit141141
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The controller function requires some changes.
After making the requested changes in this review, please also check the PR for add by CSV in nix-frontend by @godaralokesh29. He has already created the frontend functionality to add multiple users via CSV.
- In that PR, remove the for loop that adds users one by one and instead use + test your API directly.
- (For later) In the current manual signup of a single user, he has also introduced role assignment while adding a new user. You can update the signup API later to accept and store the role of the newly added user.
|
There is a bug with roles assignment I will update it by today making sure the CSV of roles of user gets updated and not the default role gets assigned |
|
Hey I have added functionality for adding roles in /signup as well as /post-add-users please review. |
Updated deployment workflow to include permission fixes and streamlined commands.
added route for bulk adding users
Shobhit141141
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The /add-members route is working fine however, some error handling needs to be taken care of.
Note: The route is changed from
/post-add-usersto/add-members.
I have added review comment, please take a look and make the necessary updates.
|
I have added the asked changes please have a review. |
Implement User Authentication and Bulk Creation Features
Changes:
Security:
Documentation: