Skip to content

Conversation

@Raman-pro
Copy link
Contributor

Implement User Authentication and Bulk Creation Features

Changes:

  • Added route for adding bulk user accessible to user with permission 0.

Security:

  • Password hashing using bcrypt
  • and only authorised user with permission 0 can access the route

Documentation:

  • Added JSDoc comments for /post-add-users

Copy link
Member

@Shobhit141141 Shobhit141141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The controller function requires some changes.

After making the requested changes in this review, please also check the PR for add by CSV in nix-frontend by @godaralokesh29. He has already created the frontend functionality to add multiple users via CSV.

  • In that PR, remove the for loop that adds users one by one and instead use + test your API directly.
  • (For later) In the current manual signup of a single user, he has also introduced role assignment while adding a new user. You can update the signup API later to accept and store the role of the newly added user.

@Raman-pro
Copy link
Contributor Author

There is a bug with roles assignment I will update it by today making sure the CSV of roles of user gets updated and not the default role gets assigned

@Raman-pro
Copy link
Contributor Author

Raman-pro commented Sep 2, 2025

Hey I have added functionality for adding roles in /signup as well as /post-add-users please review.

Copy link
Member

@Shobhit141141 Shobhit141141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /add-members route is working fine however, some error handling needs to be taken care of.

Note: The route is changed from /post-add-users to /add-members.

I have added review comment, please take a look and make the necessary updates.

@Raman-pro
Copy link
Contributor Author

I have added the asked changes please have a review.

@Shobhit141141 Shobhit141141 merged commit 814a14e into dtutimes:main Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants