role update email feature successfully implemented #126
Conversation
|
|
||
| await user.save(); | ||
|
|
||
| if (req.body.team_role !== undefined && process.env.ENABLE_EMAIL === "true") { |
There was a problem hiding this comment.
can be good to add a comment here explaining why we send an email when team role is not defined.
also will the email be sent even if some permissions are updated ?
There was a problem hiding this comment.
now every superuser will receive the same email for change in permission
added a few comments
the email will be sent even if only PERMISSIONS are updated
There was a problem hiding this comment.
Went through the new commit.
Contrary to your though process, looking superuser with this way will actually fetch all user since no permission criteria is given.
You should rather use the getUsersFromRoleID with role id of superuser (available as environment variable).
dvishal485
left a comment
dvishal485
left a comment
There was a problem hiding this comment.
update superuser fetch logic
3 participants
No description provided.