Align PhfSet key access operation parameter bounds with PhfMap
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic type bounds on `PhfSet`'s `get` and `contains` methods for the key are too restrictive, preventing the indexing of a `&'static str` `PhfSet` by a `&String`, for example. The underlying cause is the missing `Borrow` bound on the indexing type to let client code use any type that can be borrowed to the key type, even if it's not necessarily the same type. `PhfMap` already has these more ergonomic bounds, so there is no reason I can see for `PhfSet` to be different in this regard. So these changes bring more API parity between both collections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic type bounds on
PhfSet'sgetandcontainsmethods for the key are too restrictive, preventing the indexing of a&'static strPhfSetby a&String, for example. The underlying cause is the missingBorrowbound on the indexing type to let client code use any type that can be borrowed to the key type, even if it's not necessarily the same type.PhfMapalready has these more ergonomic bounds, so there is no reason I can see forPhfSetto be different in this regard. So these changes bring more API parity between both collections.