Skip to content

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Jul 19, 2025

Rustc nightly-2025-07-19 has begun warning about this. rust-lang/rust#143845

warning: `#[automatically_derived]` only has an effect on trait implementation blocks
  --> demo/src/main.rs:23:12
   |
23 |         fn put(&self, parts: &mut MultiBuf) -> u64;
   |            ^^^
   |
   = note: `#[warn(unused_attributes)]` on by default

warning: `#[automatically_derived]` only has an effect on trait implementation blocks
  --> demo/src/main.rs:24:12
   |
24 |         fn tag(&self, blobid: u64, tag: &str);
   |            ^^^

warning: `#[automatically_derived]` only has an effect on trait implementation blocks
  --> demo/src/main.rs:25:12
   |
25 |         fn metadata(&self, blobid: u64) -> BlobMetadata;
   |            ^^^^^^^^

Rustc nightly-2025-07-19 has begun warning about this.

    warning: `#[automatically_derived]` only has an effect on trait implementation blocks
      --> demo/src/main.rs:23:12
       |
    23 |         fn put(&self, parts: &mut MultiBuf) -> u64;
       |            ^^^
       |
       = note: `#[warn(unused_attributes)]` on by default

    warning: `#[automatically_derived]` only has an effect on trait implementation blocks
      --> demo/src/main.rs:24:12
       |
    24 |         fn tag(&self, blobid: u64, tag: &str);
       |            ^^^

    warning: `#[automatically_derived]` only has an effect on trait implementation blocks
      --> demo/src/main.rs:25:12
       |
    25 |         fn metadata(&self, blobid: u64) -> BlobMetadata;
       |            ^^^^^^^^
@dtolnay dtolnay merged commit 8531c59 into master Jul 19, 2025
38 checks passed
@dtolnay dtolnay deleted the autderive branch July 19, 2025 03:14
facebook-github-bot pushed a commit to facebookincubator/reindeer that referenced this pull request Sep 29, 2025
Summary: Starting in 1.90.0 a warning is generated for this attribute. This diff copies the [fix from the main cxx repo](dtolnay/cxx#1537)

Reviewed By: dtolnay

Differential Revision: D83271538

fbshipit-source-id: 7e3e4dc853882aa958e7824b2ae4aadfb30cc584
facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this pull request Sep 29, 2025
Summary: Starting in 1.90.0 a warning is generated for this attribute. This diff copies the [fix from the main cxx repo](dtolnay/cxx#1537)

Reviewed By: dtolnay

Differential Revision: D83271538

fbshipit-source-id: 7e3e4dc853882aa958e7824b2ae4aadfb30cc584
facebook-github-bot pushed a commit to facebook/sapling that referenced this pull request Sep 29, 2025
Summary: Starting in 1.90.0 a warning is generated for this attribute. This diff copies the [fix from the main cxx repo](dtolnay/cxx#1537)

Reviewed By: dtolnay

Differential Revision: D83271538

fbshipit-source-id: 7e3e4dc853882aa958e7824b2ae4aadfb30cc584
facebook-github-bot pushed a commit to facebook/pyrefly that referenced this pull request Sep 29, 2025
Summary: Starting in 1.90.0 a warning is generated for this attribute. This diff copies the [fix from the main cxx repo](dtolnay/cxx#1537)

Reviewed By: dtolnay

Differential Revision: D83271538

fbshipit-source-id: 7e3e4dc853882aa958e7824b2ae4aadfb30cc584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant