Skip to content

Bugfix workflow execute dtmfailureexception #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yxou
Copy link
Contributor

@yxou yxou commented Apr 24, 2025

At the end of the Workflow.Process method, an exception will be thrown if the exception is not null, so that the caller can accurately obtain the exception information.
Adjust the two single tests of WorkflowHttpTests to accommodate exception messages thrown.

yxou added 2 commits April 23, 2025 17:18

Change the test method name to a more accurate description, and update the test logic to expect a 'DtmFailureException' instead of returning 'null'. This enhances the verification of exception handling.
…to make sure an error is thrown if 'err' is not null. Modify the exception assertion of the 'Rollback_Should_Be_Executed' single test to use 'Assert.ThrowsAsync' to verify whether a 'DtmFailureException' was thrown.
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (8c65784) to head (447cda1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   70.15%   70.18%   +0.02%     
==========================================
  Files          45       45              
  Lines        1997     1999       +2     
  Branches      195      196       +1     
==========================================
+ Hits         1401     1403       +2     
  Misses        558      558              
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yxou yxou closed this Apr 24, 2025
@yxou yxou reopened this Apr 24, 2025
Copy link
Member

@catcherwong catcherwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catcherwong catcherwong merged commit 16f174d into dtm-labs:main Apr 25, 2025
10 of 11 checks passed
@yxou yxou deleted the bugfix-workflow-execute-dtmfailureexception branch April 27, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants