This repository was archived by the owner on May 7, 2024. It is now read-only.
Remove unnecessary usage of app_ctx_stack #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only used to check if the application context exists, and if it didn't exist an exception was raised with an explanatory message. Trying to access current_app._get_current_object() raises the same kind of exception with an equivalent explanatory message, therefore the usage of app_ctx_stack and the check around it was completely redundant.
|
I wish this would merge.. the warnings I'm getting are an annoyance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only used to check if the application context exists, and if it didn't exist an exception was raised with an explanatory message.
Trying to access current_app._get_current_object() raises the same kind of exception with an equivalent explanatory message, therefore the usage of app_ctx_stack and the check around it was completely redundant.
Fixes issue #16
Requires PR #15