Repository navigation
Expose decoder progress - #248
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1229 1266 +37
=========================================
+ Hits 1229 1266 +37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dspicher
left a comment
dspicher
left a comment
There was a problem hiding this comment.
Thanks for the PR!
If you are willing to share, I would be curious what you use the crate for :)
|
Can you rebase on master? |
| /// [`complete`]: Decoder::complete | ||
| /// [`fragment_count`]: Decoder::fragment_count | ||
| #[must_use] | ||
| pub fn resolved_fragment_count(&self) -> Option<usize> { |
There was a problem hiding this comment.
Sorry, I had mistakenly posted my previous comment on the wrong method.
This we fundamentally know in the beginning, even before any part has been received: We have resolved zero fragments. So this should return usize.
Please squash all commits into one when you're done, thanks!
There was a problem hiding this comment.
As the previous implementation already did what you are asking and the current one improved on that, even if it was the wrong comment, couldn't we keep it like it is now? I think it's nice to distinguish between None and Some(0)
There was a problem hiding this comment.
That's true, Some(0) is also possible 👍
Could you squash please?
|
Published as part of 0.5.0: https://github.com/dspicher/ur-rs/releases/tag/0.5.0 |
No description provided.