Fix v3 TagExifA301SceneType decoder #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuchl4n3k
commented
Aug 20, 2025
stuchl4n3k
commented
- Decoding the value as long gives scene type value 16777216 instead of 1 ("Directly photographed").
- Decoding the value as long gives scene type value 16777216 instead of 1.
ctruta
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
I just tested this fix locally and I confirm the updated test is passing.
I also confirm it is a correct fix of an endianness issue. The current bug (16777216 vs 1) is a classic big-endian interpretation of a single byte as a 4-byte integer. It should read one byte and expect value 1 "directly photographed scene".
You can see the tag 0xa301 SceneType referenced here:
https://exiftool.org/TagNames/EXIF.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.