fix: escapeArg was not escaping multiple quotes (#194)

dsherret · Dec 17, 2023 · e0386dd · e0386dd
1 parent fc2ea78
commit e0386dd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/command.test.ts b/src/command.test.ts
@@ -0,0 +1,8 @@
+import { escapeArg } from "./command.ts";
+import { assertEquals } from "./deps.test.ts";
+
+Deno.test("escapes arg", () => {
+  assertEquals(escapeArg("hello"), "hello");
+  assertEquals(escapeArg(""), "''");
+  assertEquals(escapeArg("'abc'"), `''"'"'abc'"'"''`);
+});
diff --git a/src/command.ts b/src/command.ts
@@ -875,10 +875,10 @@ function buildEnv(env: Record<string, string | undefined>) {
 
 export function escapeArg(arg: string) {
   // very basic for now
-  if (/^[A-Za-z0-9]*$/.test(arg)) {
+  if (/^[A-Za-z0-9]+$/.test(arg)) {
     return arg;
   } else {
-    return `'${arg.replace("'", `'"'"'`)}'`;
+    return `'${arg.replaceAll("'", `'"'"'`)}'`;
   }
 }